Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: omit previousResult, lastCompleteResult from options/result #10100

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

alessbell
Copy link
Member

After discussing with @benjamn today, it was determined previousResult can be omitted from UseFragmentOptions.

In documenting UseFragmentResult in PR #10099, it seems we may be able to omit previousResult and lastCompleteResult from the result type as well. I've done some logging in our tests and don't see where they're used, but happy to add them back if they are.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@alessbell alessbell merged commit e009319 into release-3.7 Sep 13, 2022
@benjamn benjamn deleted the useFragment-omit-previousResult branch September 15, 2022 18:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants