Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apollo-link-rest.md - Add graphql-anywhere to install list #10138

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

pfcodes
Copy link
Contributor

@pfcodes pfcodes commented Sep 28, 2022

Added graphql-anywhere to the install string. apollo-link-rest does not work without this library installed.

Somewhat related:
apollographql/apollo-link-rest#295

@apollo-cla
Copy link

@pfcodes: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@jpvajda
Copy link
Contributor

jpvajda commented Sep 29, 2022

Here is the error I am getting when trying to follow the instructions from this docs page

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: apollo-client-error-template@1.0.0
npm ERR! Found: graphql@16.6.0
npm ERR! node_modules/graphql
npm ERR!   graphql@"^16.6.0" from the root project
npm ERR!   peer graphql@">=0.11" from apollo-link-rest@0.9.0-rc.1
npm ERR!   node_modules/apollo-link-rest
npm ERR!     apollo-link-rest@"*" from the root project
npm ERR!   3 more (@apollo/client, graphql-ws, subscriptions-transport-ws)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer graphql@"^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0" from graphql-anywhere@4.2.7
npm ERR! node_modules/graphql-anywhere
npm ERR!   peer graphql-anywhere@">=4" from apollo-link-rest@0.9.0-rc.1
npm ERR!   node_modules/apollo-link-rest
npm ERR!     apollo-link-rest@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/jvajda/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:

Given the state of the graphql anywhere project, I'm not sure we want to reference this package in the documentation, however it brings up a question of what should we do here. I'll discuss with the team @pfcodes Thanks for bring this to our attention.

@jpvajda jpvajda self-assigned this Sep 29, 2022
@bignimbus bignimbus merged commit b0cef62 into apollographql:main Oct 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants