Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Local Resolvers docs #10211

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Update Local Resolvers docs #10211

merged 1 commit into from
Oct 19, 2022

Conversation

bignimbus
Copy link
Contributor

Fixes #10210

  • Remove deprecation verbiage
  • Retain local-only fields recommendation
  • Wordsmith explanation of future plans

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

benjamn
benjamn approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ ⇒ 🎶

@bignimbus bignimbus force-pushed the bignimbus/local-resolvers-docs branch from 56ef135 to 0ca5bd9 Compare October 19, 2022 18:41
@bignimbus @alessbell
Update Local Resolvers docs
f778382 
* Remove deprecation verbiage
* Retain local-only fields recommendation
* Wordsmith explanation of future plans

Co-authored-by: Alessia Bellisario <alessia@apollographql.com>
@bignimbus bignimbus force-pushed the bignimbus/local-resolvers-docs branch from 0ca5bd9 to f778382 Compare October 19, 2022 19:14
@bignimbus bignimbus merged commit 8bfdec1 into main Oct 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@jpvajda jpvajda Awaiting requested review from jpvajda

@jerelmiller jerelmiller Awaiting requested review from jerelmiller

@MrDoomBringer MrDoomBringer Awaiting requested review from MrDoomBringer

@alessbell alessbell Awaiting requested review from alessbell

Assignees
No one assigned
Labels
📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Local Resolvers documentation wording
3 participants
@bignimbus @benjamn @alessbell