Call forceUpdate immediately if diff changes between first useFragment call and first cache.watch call
#10212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
Oct 19, 2022
|
Alas, that test failure is the same one I was trying to fix in #10118, so I guess we're back to where we started. |
benjamn
force-pushed
the
attempt-to-fix-flaky-useFragment-test
branch
from
2b12820
to
8c40bd1
Compare
benjamn
changed the title
useFragment test by removing needless Promise logicforceUpdate immediately if diff changes between first useFragment call and first cache.watch
benjamn
changed the title
forceUpdate immediately if diff changes between first useFragment call and first cache.watchforceUpdate immediately if diff changes between first useFragment call and first cache.watch call
benjamn
commented
Oct 19, 2022
alessbell
approved these changes
Oct 19, 2022
Because useSyncExternalStore does not call the subscribe function until an internal useEffect fires, there's a real chance the latest data from the cache have changed in the meantime, so it's not useless to check for changes right away and potentially call forceUpdate. Passing immediate:true to cache.watch ensures the callback will be called right away, rather than the _next_ time relevant data change.
benjamn
force-pushed
the
attempt-to-fix-flaky-useFragment-test
branch
from
8c40bd1
to
b964d7b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
useFragmenttest has been failing locally for me and has even failed onmainfor otherwise innocuous commits like 2db905f (failing CI job).I added this
Promiselogic in #10118 to fix another flakiness issue, but the current state seems worse (more frequent failures) than before.