Add @defer support to useSuspenseQuery
#10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
commented
Dec 3, 2022
jerelmiller
force-pushed
the
react-suspense-defer
branch
from
94168e5
to
e0db997
Compare
This was referenced Dec 6, 2022
Closed
jerelmiller
force-pushed
the
react-suspense
branch
3 times, most recently
from
f65b6c5
to
f4e0ece
Compare
jerelmiller
force-pushed
the
react-suspense-defer
branch
from
e0db997
to
3354562
Compare
🦋 Changeset detectedLatest commit: f164786 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jerelmiller
force-pushed
the
react-suspense-defer
branch
3 times, most recently
from
bcb2e7b
to
6eec38c
Compare
jerelmiller
force-pushed
the
react-suspense-defer
branch
from
5e59c45
to
1293337
Compare
jerelmiller
commented
Dec 12, 2022
| // created from `reobserve`. This function provides the original `reobserve` | ||
| // functionality, but returns a concast instead of a promise. Most consumers | ||
| // should prefer `reobserve` instead of this function. | ||
| public reobserveAsConcast( |
There was a problem hiding this comment.
Feel free to suggest a different name for this
alessbell
approved these changes
Dec 21, 2022
|
Same test is flaky as the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #10231 and #10286
Adds
@defersupport foruseSuspenseQueryusage. Detailed design on behavior can be found in the RFC under the "Usage with @defer" heading.Checklist: