Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers type (extends #9042) #10471

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Fix headers type (extends #9042) #10471

merged 3 commits into from
Jan 23, 2023

Conversation

alessbell
Copy link
Member

Narrows headers type as began by @alias-mac in #9042.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

alias-mac and others added 3 commits January 23, 2023 15:22
When passing the headers property to `createHttpLink` one might think
that it is ok to pass them as `Headers` interface, but that doesn't work
because there is several places in the code that expect headers to be
passed as an object.
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: 1f890cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🔥

Thanks for getting this ported over!

@jerelmiller jerelmiller merged commit 895ddcb into main Jan 23, 2023
@jerelmiller jerelmiller deleted the fix-headers-type branch January 23, 2023 21:12
This was referenced Jan 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants