Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmounting a component before a query is resolved via useLazyQuery lets the promise resolve instead of aborting the promise. #10698

Merged
merged 15 commits into from
Mar 31, 2023
Merged

Unmounting a component before a query is resolved via useLazyQuery lets the promise resolve instead of aborting the promise. #10698

merged 15 commits into from
Mar 31, 2023

Commits on Mar 31, 2023

  1. Restore useLazyQuery to original non-resolved promise.

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    dc93168 View commit details
    Browse the repository at this point in the history

  2. Allow pending promises kicked off by useLazyQuery to fully resolve ra… 

    …ther than aborting them when unmounting the component
    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    606b125 View commit details
    Browse the repository at this point in the history

  3. Add tests to validate that executing the query multiple times results… 

    … in the right resolved data.
    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    9f8fa33 View commit details
    Browse the repository at this point in the history

  4. Add a test to validate the most recent options set is used when reren… 

    …dering.
    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    f35941c View commit details
    Browse the repository at this point in the history

  5. Ensure the query can be updated in useLazyQuery when rerendering

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    056dc51 View commit details
    Browse the repository at this point in the history

  6. Set this.watchQueryOptions inline

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    01d0da3 View commit details
    Browse the repository at this point in the history

  7. Update test to run execution functions in parallel to better simulate… 

    … intended behavior
    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2b920eb View commit details
    Browse the repository at this point in the history

  8. Add test to confirm rerendering after execution does not refetch

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    5cf4dee View commit details
    Browse the repository at this point in the history

  9. Consolidate tests and add link to issue in comment

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    273a6f8 View commit details
    Browse the repository at this point in the history

  10. Add link to issue above test

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    56c97a1 View commit details
    Browse the repository at this point in the history

  11. Use the merged variable for the options ref

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    36121d3 View commit details
    Browse the repository at this point in the history

  12. Add changeset

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    604f2ce View commit details
    Browse the repository at this point in the history

  13. Remove outdated comment

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    d441606 View commit details
    Browse the repository at this point in the history

  14. Minor tweaks to changeset description

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    a2c34e1 View commit details
    Browse the repository at this point in the history

  15. Add comment justifying the refs

    @jerelmiller
    jerelmiller committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    18be640 View commit details
    Browse the repository at this point in the history