Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphQLErrors in Error Link if networkError.result is an empty string #11329

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

PaLy
Copy link
Contributor

@PaLy PaLy commented Oct 31, 2023

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@PaLy: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Oct 31, 2023

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 76eeb3e

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: 76eeb3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for the long wait on this PR! I've been meaning to look at this for a while and it slipped down my list, so apologies.

This looks great! I'll get the one suggestion committed, but I'll get this in the next patch release 🙂

src/link/error/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jerelmiller jerelmiller merged commit 3d164ea into apollographql:main Jun 12, 2024
39 of 40 checks passed
@jerelmiller jerelmiller removed the 🏓 awaiting-team-response requires input from the apollo team label Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphQLErrors property passed to onError is sometimes an empty string
3 participants