-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BatchMaxQueries #1659
Merged
Merged
BatchMaxQueries #1659
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9eb223e
added batchMax to QueryBatcher which slices the queue in batchMax ite…
happylinks 4aa4795
fixed broken tests and tried to make a new test for batchMax
happylinks 0f6d8be
Merge branch 'master' into batchMax
helfer 99a2881
changed batchMax to consumeQueue directly when queue hits max, fixed …
happylinks b2b02b3
fixed conflict
happylinks 2189f13
fixed conflict
happylinks 485882d
don't make http call when no queuedrequests
happylinks 52e18d2
Merge branch 'master' into batchMax
happylinks 3c906b9
Merge branch 'master' into batchMax
helfer d587866
Merge branch 'master' into batchMax
happylinks 0c9392b
Added batchMax default value and new test to make sure it doesnt fire…
happylinks fcc2da7
fixed conflict
happylinks 6bfbd24
removed unneeded batchMax from tests
happylinks ffdacaf
Merge branch 'master' into batchMax
happylinks f30b41a
fixed tests
happylinks 74239ad
updated CHANGELOG.md
happylinks a8ecb34
Merge branch 'master' into batchMax
helfer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test looks good! After making
batchMax
optional, please also add a test that checks that no batching happens ifbatchMax
is set to zero.