Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic interoperability with other Observable implementations #196

Merged
merged 1 commit into from May 10, 2016

Conversation

martijnwalraven
Copy link
Contributor

Closes #149.

@stubailo
Copy link
Contributor

@martijnwalraven hey, I don't know how this happened, but it looks like you skipped the PR checklist, which included "add this to the changelog". Can you please add a changelog entry about this?

@stubailo
Copy link
Contributor

@martijnwalraven also, the CI tests didn't pass on this PR.

@martijnwalraven martijnwalraven deleted the rxjs-interoperability branch May 11, 2016 04:04
@martijnwalraven
Copy link
Contributor Author

@stubailo: Sorry I missed the changelog. I've added it to the 0.3.5 section because it was included in that release.

The tests passed on the CI but I missed the linter errors. Thanks for fixing these.

@stubailo
Copy link
Contributor

Yeah no problem! Next time just wait until Travis is done before merging.

@martijnwalraven
Copy link
Contributor Author

I actually did look at the CI results but figured there was something else wrong because the tests themselves passed. Should have taken a closer look at the logs and spotted the linter errors.

jbaxleyiii pushed a commit that referenced this pull request Oct 18, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants