New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat dates properly in isEqual
#2131
Conversation
@nl0: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
@nl0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @calebmer and @jbaxleyiii to be potential reviewers. |
Generated by 🚫 dangerJS |
So, the issues found by CI are fixed. There were no tests for isEqual and I haven't added any. |
@jbaxleyiii hi! Any update on this? It blocks the feature I'm currently working on. Anything I can help you with? |
@nl0 merging now! This will be in the next latest and in the beta! I'll work to get the next latest released this week! sorry for the delay! |
@jbaxleyiii thanks a lot! 🍻 |
@jbaxleyiii hey. sorry for bothering you again, but do you have any eta on the next 1.x release? |
@jbaxleyiii nvm, just noticed the new version in the registry. thanks again for your work on the project! |
Hey there.
I've stumbled upon a bug where my query wasn't updated and refetched when I was changing the variables object (calculated from props) that contained dates. I've tracked it down to the
isEqual
util function, which treated different dates as equal.Should I add some tests to cover this case?