Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(apollo-utilities): unstable stringify key #2869

Merged
merged 11 commits into from
Jun 1, 2018
Merged

(apollo-utilities): unstable stringify key #2869

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
10065bc
fix(apollo-utilities): unstable stringify key
PatrickJS Jan 15, 2018
dbd5a8e
Merge branch 'master' into fix-unstable-stringify-key
Jan 16, 2018
b2fbd5a
Merge branch 'master' into fix-unstable-stringify-key
Mar 23, 2018
6951dbe
Merge remote-tracking branch 'upstream/master' into fix-unstable-stri…
hwillson May 18, 2018
55b2ed6
Removed duplicate `stringify` line
hwillson May 18, 2018
32c39e9
Use `fast-json-stable-stringify`, add tests
hwillson May 18, 2018
1a14147
Update CHANGELOG
hwillson May 18, 2018
4cabf02
Adjust cache tests to respect new deterministic key names
hwillson May 18, 2018
89098af
Increase allowed `apollo-utilities` bundle size
hwillson May 18, 2018
8c70ceb
Merge branch 'master' into fix-unstable-stringify-key
hwillson May 25, 2018
d9d4016
Merge remote-tracking branch 'upstream/master' into fix-unstable-stri…
hwillson Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/apollo-utilities/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@
"minify:browser": "uglifyjs -c -m -o ./lib/bundle.min.js -- ./lib/bundle.js",
"filesize": "npm run build && npm run build:browser"
},
"dependencies": {
"json-stable-stringify": "1.0.1"
},
"devDependencies": {
"@types/json-stable-stringify": "1.0.32",
"@types/graphql": "0.12.5",
"@types/jest": "21.1.10",
"@types/lodash": "4.14.105",
Expand Down
3 changes: 3 additions & 0 deletions packages/apollo-utilities/src/storeUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import {
NameNode,
} from 'graphql';

import * as stringify from 'json-stable-stringify';

export interface IdValue {
type: 'id';
id: string;
Expand Down Expand Up @@ -216,6 +218,7 @@ export function getStoreKeyName(
let completeFieldName: string = fieldName;

if (args) {
const stringifiedArgs: string = stringify(args);
const stringifiedArgs: string = JSON.stringify(args);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be removed (rebase/merge problem)

completeFieldName += `(${stringifiedArgs})`;
}
Expand Down