First pass at disabling force-fetch in SSR contexts #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty good to me! |
|
Added tests, please take a look. |
| @@ -879,4 +880,103 @@ describe('client', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe.only('forceFetch', () => { | |||
There was a problem hiding this comment.
What does describe.only do?
There was a problem hiding this comment.
Whoops, just runs those tests.
|
Looks good to me! |
|
Hmm, and somehow I broke other tests, investigating. |
tmeasday
force-pushed
the
298-ssr-disable-force-fetch
branch
from
c867ec8
to
0bef530
Compare
|
Ok, this is working now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a start in the direction of #298
If we think it's the right approach (modifying query options at the
ApolloClientlayer), then I'll add tests and turn it into a proper PR.TODO: