Remove Object.setPrototypeOf() #3306
Conversation
Object.setPrototypeOf() doesn't work on Android
Generated by 🚫 dangerJS |
|
This LGTM for compatibility purposes. In a future PR, when should reconsider setting the prototype directly as it will cause JITs to deoptimize. |
|
@seklyza can you resolve your conflicts and then merge the PR, please?? |
|
Is this going to get cleaned up and merged? Only conflict is CHANGELOG.md |
| # Change log | ||
|
|
||
| ### vNext | ||
|
|
||
| - Fixed an issue involving `Object.setPrototypeOf()` not working on JSC |
There was a problem hiding this comment.
I've adjusted the comment here to be a bit more descriptive.
| @@ -65,6 +65,6 @@ export class ApolloError extends Error { | |||
|
|
|||
| this.extraInfo = extraInfo; | |||
|
|
|||
| Object.setPrototypeOf(this, ApolloError.prototype); | |||
| (this as any).__proto__ = ApolloError.prototype; | |||
There was a problem hiding this comment.
I think we should add a comment here explaining why we aren't using Object.setPrototypeOf. Otherwise someone might add it back in the future.
Fixes #3236
Object.setPrototypeOf()does not work on JSC (Android). Instead, we're setting the prototype ofthismanually.