Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arrays to graphql-anywhere filter function - Issue #3483 #3591

Merged
merged 5 commits into from
Jul 10, 2018
Merged

Add support for arrays to graphql-anywhere filter function - Issue #3483 #3591

merged 5 commits into from
Jul 10, 2018

Conversation

JSweet314
Copy link
Contributor

@JSweet314 JSweet314 commented Jun 16, 2018 •
edited
Loading

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@apollo-cla
Copy link

@JSweet314: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added feature labels Jun 16, 2018
JSweet314 and others added 2 commits June 16, 2018 17:36
@JSweet314
Add check for array of data
7aac9f9 
Return a mapping of data objects to an array of filtered data objects
@JSweet314
Update CHANGELOG.md
ec657bd
@0styx0
Copy link

0styx0 commented Jun 18, 2018

I think this is for issue #3483, one off

@JSweet314 JSweet314 changed the title Add support for arrays to graphql-anywhere filter function - Issue #3482 Add support for arrays to graphql-anywhere filter function - Issue #3483 Jun 19, 2018
hwillson
hwillson approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @JSweet314 - thanks very much!

@hwillson hwillson merged commit 400e3c3 into apollographql:master Jul 10, 2018
@dependencies dependencies bot mentioned this pull request Jul 25, 2018
Open
@hwillson hwillson mentioned this pull request Jul 27, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JSweet314 @apollo-cla @0styx0 @hwillson