Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-apollo-migration.md #3819

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Conversation

yalamber
Copy link
Contributor

wrap Apollo consumer example in a div.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

wrap Apollo consumer example in a div.
@apollo-cla
Copy link

@yalamber: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yalamber!

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #3819 into master will increase coverage by 1.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
+ Coverage   87.64%   89.18%   +1.53%     
==========================================
  Files          32       43      +11     
  Lines        1757     2357     +600     
  Branches      434      564     +130     
==========================================
+ Hits         1540     2102     +562     
- Misses        203      239      +36     
- Partials       14       16       +2
Impacted Files Coverage Δ
packages/apollo-cache-inmemory/src/index.ts 100% <0%> (ø)
packages/apollo-cache/src/cache.ts 100% <0%> (ø)
packages/apollo-boost/src/index.ts 88.7% <0%> (ø)
packages/apollo-cache-inmemory/src/objectCache.ts 100% <0%> (ø)
packages/apollo-cache/src/utils.ts 100% <0%> (ø)
...ackages/apollo-cache-inmemory/src/readFromStore.ts 97.72% <0%> (ø)
packages/apollo-cache-inmemory/src/writeToStore.ts 98.13% <0%> (ø)
...kages/apollo-cache-inmemory/src/fragmentMatcher.ts 90.9% <0%> (ø)
...ckages/apollo-cache-inmemory/src/recordingCache.ts 86.2% <0%> (ø)
packages/apollo-cache-inmemory/src/mapCache.ts 100% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2052beb...f909e25. Read the comment docs.

@hwillson hwillson merged commit e0599e2 into apollographql:master Aug 17, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants