Optimist tests cleanup #2 #3834
Conversation
joshribakoff
force-pushed
the
cleanup_optimist_2
branch
from
a702626
to
6f25d94
Compare
joshribakoff
changed the title
|
This PR is complete. In my next PR, I will most likely extract test helpers http://xunitpatterns.com/Test%20Helper.html, several rounds of flattening after that would most likely be called for, before I attempt to write failing tests for & fix the underlying bug. My goal is 4-7 LOC for each test in this file. |
|
This article might help filter the white space changes, only a few lines actually changed. https://michaelheap.com/a-better-git-diff/ |
|
Is there anything I can do to expedite this? Can I work on any bug fixes or code reviews that would free up more of your time to review this? Would I be able to send bigger PRs, or a larger change set split up into multiple PRs but all at once? I feel like I could greatly simplify these tests, and I could move much more quickly & the code sitting in PR review is the only bottleneck here from my perspective. |
As discussed in #3712 this is a continuation of PR #3713 further cleaning up the tests