added test to readQuery #3838
added test to readQuery #3838
Conversation
|
@CarloPalinckx: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
It would be better use 'deep-freeze' package to ensure the argument is not changeable. |
I think I don't really agree on this. Not mutating arguments that are passed by reference is a pretty common best practice. With this added test we at least confirm that it doesn't happen. Which should be enough imo. |
| }, | ||
| }; | ||
|
|
||
| const preQueryCopy = { ...args }; |
There was a problem hiding this comment.
Did you mean for this to be a deep copy? The { ...obj } syntax just copies the top level of the object.
There was a problem hiding this comment.
Yes I did! good spot. I see lodash is already installed so i'll just use cloneDeep here.
Adds a test to ensure that passed in arguments aren't mutated after a
readQueryas requested per issue: #2464Fixes #2464.