Replace custom cloneDeep function
#3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom `cloneDeep` function we're using in the `apollo-utilities` package doesn't handle circular references well (as in it crashes if it hits one). These changes replace the custom `cloneDeep` implementation with `fclone`, which is a dependency free, lightweight and performant deep clone implementation. `fclone` drops circular references (replacing them with a `[Circular]` string). Fixes #1717.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom
cloneDeepfunction we're using in theapollo-utilitiespackage doesn't handle circular references well (as in it crashes if it hits one). These changes replace the customcloneDeepimplementation withfclone, which is a dependency free, lightweight and performant deep clone implementation.fclonedrops circular references (replacing them with a[Circular]string).Fixes #1717.