Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apollo-cache-inmemory in IE11 #4012

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Fix apollo-cache-inmemory in IE11 #4012

merged 3 commits into from
Oct 24, 2018

Commits on Oct 24, 2018

  1. Fix apollo-cache-inmemory in IE11 

    In IE11, Map.prototype.set is not spec-compliant and returns undefined.
This commit removes the chained calls on Map to avoid the TypeError.
    @ooflorent @benjamn
    ooflorent authored and benjamn committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    39778af View commit details
    Browse the repository at this point in the history

  2. Polyfill correct Map#set and Set#add return behavior. 

    Implementing my own suggestion:
apollographql#4012 (review)

This change would be sufficient to fix apollographql#4024, though apollographql#4012 helps as well.
    @benjamn
    benjamn committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    61262b3 View commit details
    Browse the repository at this point in the history

  3. Bump apollo-cache-inmemory maxSize to make tests pass.

    @benjamn
    benjamn committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    f74e82d View commit details
    Browse the repository at this point in the history