Avoid copying non-enumerable and/or symbol keys in cloneDeep. #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4039 (comment) The previous fclone implementation didn't bother with non-enumerable or non-string keys, either, so this is not a breaking change. The Date case was also a bit overzealous, since there are no actual use cases in this codebase that require Date objects to be duplicated, rather than simply passing them through. If we're missing any cases that anyone cares about, we can easily expand the switch-case coverage in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4039 (comment)
The previous
fcloneimplementation did not preserve non-enumerable or non-string keys either (see here), so this is not a breaking change.The
Datecase was also a bit overzealous, since there are no actual use cases in this codebase that requireDateobjects to be duplicated, rather than simply passing them through.If we're missing any cases that anyone cares about, we can easily expand the
switch-casecoverage in the future.