Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to add listeners for clearStore #4082

Merged

Conversation

joe-re
Copy link
Contributor

@joe-re joe-re commented Oct 31, 2018

ref: apollographql/apollo-feature-requests#53

Add onClearStore method to client instance for hook clearStore.
This provides us to manage some kinda application lifecycle after clearStore, certainly.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@joe-re: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@joe-re joe-re force-pushed the enable-to-add-listeners-for-clearStore branch 2 times, most recently from 2d1c003 to 7adcdb4 Compare November 2, 2018 19:35
@joe-re joe-re force-pushed the enable-to-add-listeners-for-clearStore branch from 7adcdb4 to 6a0ca69 Compare November 4, 2018 09:23
@hwillson hwillson added this to Current Sprint in Apollo Client Dec 12, 2018
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @joe-re - thanks very much!

@hwillson hwillson moved this from Current Sprint to In Progress in Apollo Client Jan 2, 2019
@hwillson hwillson merged commit 183c81d into apollographql:master Jan 2, 2019
@hwillson hwillson moved this from In Progress to Done in Apollo Client Jan 2, 2019
@joe-re joe-re deleted the enable-to-add-listeners-for-clearStore branch January 27, 2019 15:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Apollo Client
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants