Update Typescript to 2.0 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mquandalle
force-pushed
the
typescript-2.0
branch
from
95b591b
to
c5172c3
Compare
|
Thanks for doing this! I'll check it out sometime soon. |
|
Will this in any way affect people who are using Apollo Client with Typescript 1.x? |
|
No, not until the types definition file is modified. With this PR, it’s just the compilation-step analysis that is enhanced, but the .js and .d.ts builds are the same. |
That's odd, since there is a |
|
Hum, after some investigations, I think this is an instance of microsoft/TypeScript#7719. |
Updating graphql-tag was also required because its incorect types definition was raising errors with TS 2.0, see apollographql/graphql-tag#1. I haven’t opt-in for the `strictNullChecks` option yet, for that’s certainly something to do to get the full benefit of this new TS release.
mquandalle
force-pushed
the
typescript-2.0
branch
from
c5172c3
to
696dd55
Compare
mquandalle
force-pushed
the
typescript-2.0
branch
from
696dd55
to
70e2276
Compare
|
Looks good to go for me, gonna merge once the tests pass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The soon-to-be-released v2.0 of TypeScript will bring a lot of new cool features. Cherry-picking the releases notes, I believe the apollo-client will especially benefit from the discriminated union types (microsoft/TypeScript#9163), the smarter flow analysis, and the explicit
nullandundefinedchecks.This PR updates the Typescript compiler to use the v2.0-beta. There is one logic error detected by the new flow analysis:
I haven’t opt-in the
strictNullChecksoption as I’m not that comfortable with the code base, but it sure would be great if someone else could do it.