Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export isApolloError #4223

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Export isApolloError #4223

merged 4 commits into from
Jan 2, 2019

Conversation

danielkcz
Copy link
Contributor

I find it very handy for advanced error reporting to be able to recognize ApolloError. Even though it just checks for graphqlErrors property, in TypeScript world thanks to the type guard it gives additional layer.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@danielkcz
Copy link
Contributor Author

Welp, such a tiny addition and it has increased bundle size by 21B which is over the limit 😮

@danielkcz
Copy link
Contributor Author

@benjamn @hwillson Can you please have a look at this? It's a tiny change. I suppose the limit for bundlesize has to be increased? Cannot really do this any smaller ;)

@hwillson hwillson added this to In Progress in Apollo Client Jan 2, 2019
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion @FredyC, thanks!

@hwillson hwillson merged commit b193f2a into apollographql:master Jan 2, 2019
@hwillson hwillson moved this from In Progress to Done in Apollo Client Jan 2, 2019
@danielkcz danielkcz deleted the patch-1 branch January 2, 2019 23:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Apollo Client
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants