Revert breaking changes mistakenly released in patch update #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b4f0c8e. Should fix apollographql/react-apollo#2738, until we can find a better solution.
This reverts commit d4f3346. Although apollographql/react-apollo#2738 resulted immediately from the removal of the scheduler, similar problems will almost certainly arise from privatizing client.queryManager.
948706f The commit linked above attempted to inline tslib helpers into our UMD bundles, but accidentally left actual tslib imports in the ESM files exposed through the `module` field in `package.json`, without installing tslib as a dependency. Since we're not currently bundling all of our ESM modules together into one bundle, inlining the helpers doesn't make sense, because they would be inlined at the top of every module where they were used, instead of being shared across all modules. However, importing tslib the normal way should work just fine, and tree-shaking bundlers can take care of pruning the unused helpers from the tslib package. Should fix #4332.
|
No surprise that the bundle size test failed, since these changes were originally intended (in part) to reduce bundle sizes. |
benjamn
deleted the
revert-breaking-changes-mistakenly-released-in-patch-update
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my rush to release #4234, I removed some previously public members from the
QueryManagerand forgot to include an explicit dependency on thetslibpackage. This PR reverts theQueryManagerchanges for now, at least until apollographql/react-apollo#2738 can be addressed, and fixes #4332 by addingtslibto the dependencies of all client packages.To prevent further breakage due to automatic patch updates, we will release new patch versions of the relevant packages after this PR is merged.
Once the underlying issues are fixed, we will un-revert the
QueryManagerchanges and revisit how the package versions should be bumped.