Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly type setQuery and fix now typed callers #4369

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Properly type setQuery and fix now typed callers #4369

merged 3 commits into from
Jan 29, 2019

Conversation

danilobuerger
Copy link
Contributor

Fixes #4041

hwillson
hwillson approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @danilobuerger - thanks!

@hwillson hwillson added this to In Progress in Apollo Client Jan 29, 2019
@hwillson hwillson merged commit 07a068e into apollographql:master Jan 29, 2019
@hwillson hwillson moved this from In Progress to Done in Apollo Client Jan 29, 2019
@danilobuerger danilobuerger deleted the setquery branch January 29, 2019 20:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Apollo Client
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danilobuerger @hwillson