Preserve networkStatus for incomplete cache-and-network queries. #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blindly setting networkStatus to NetworkStatus.loading after the client part of a cache-and-network query was destroying useful information about the status of the request. Instead, we should use NetworkStatus.ready only when the request is complete, and leave networkStatus untouched otherwise. Fixes #3660, #4693, and apollographql/react-apollo#1217.
benjamn
deleted the
preserve-networkStatus-for-incomplete-cache-and-network-queries
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blindly setting
networkStatustoNetworkStatus.loadingafter the client part of acache-and-networkquery was destroying useful information about the status of the request. Instead, we should setnetworkStatustoNetworkStatus.readyonly when the request is complete, and leavenetworkStatusuntouched otherwise.Should fix #3660, #4693, and apollographql/react-apollo#1217.