Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide fragmentMap to local resolvers via info parameter #5388

Merged
merged 5 commits into from
Nov 15, 2019

Conversation

mjlyons
Copy link
Contributor

@mjlyons mjlyons commented Sep 30, 2019

Implements proposal from apollographql/apollo-feature-requests#110 (cc @hwillson)

This allows local resolvers to understand what fields are selected via named fragments. Previously it wasn't possible for local resolvers to know what fields were selected by named fragments.

Includes test (and verified fails prior to this change)

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a clear improvement to me. Sorry for the delay!

@benjamn benjamn merged commit e6a1764 into apollographql:master Nov 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants