Eliminate needless custom assign utility. #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only do we have the tslib __assign helper, and folks can easily polyfill Object.assign in older browsers, but we were only using this helper in one place, and we didn't really need it, even there. Saves 78 bytes of bundle size (minified + gzip), which is pretty good for such an easy change.
This comment has been minimized.
This comment has been minimized.
benjamn
commented
Feb 20, 2020
| if (typeof source === 'undefined' || source === null) { | ||
| return; | ||
| } | ||
| Object.keys(source).forEach(key => { |
There was a problem hiding this comment.
This wasn't even correct, because Object.assign is specified to copy own Symbols as well as own keys.
hwillson
approved these changes
Feb 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only do we have the
__assignhelper fromtslibto handle{ ...object, ...spread }syntax, and folks can easily polyfillObject.assignin older browsers, but we were using thisassignhelper in only one place, and we didn't really need it there.Saves 78 bytes of bundle size (minified + gzip), which is pretty good for such an easy change.