Ensure @client @export variables in watched queries are updated #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
force-pushed
the
client-export-tweak
branch
from
69d1fb0
to
e12cb0c
Compare
benjamn
approved these changes
Feb 24, 2020
hwillson
force-pushed
the
client-export-tweak
branch
from
e12cb0c
to
e6b17c0
Compare
The changes made in #5946 helped address an issue where queries with `@client @export` variables were making unnecessary network requests. While those changes work, they're currently preventing watched queries using `@client @export` from updating the `@export`ed variable, as new data is received. This commit fixes that issue.
hwillson
force-pushed
the
client-export-tweak
branch
from
e6b17c0
to
5f558af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made in #5946 helped address an issue where queries with
@client @exportvariables were making unnecessary network requests. While those changes work, they're currently preventing watched queries using@client @exportfrom updating the@exported variable, as new data is received. This commit fixes that issue.