Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop delivering "stale" results to ObservableQuery. #6058

Merged
merged 9 commits into from
Apr 6, 2020
Merged

Stop delivering "stale" results to ObservableQuery. #6058

merged 9 commits into from
Apr 6, 2020

Commits on Apr 6, 2020

  1. Unpack private QueryCurrentObservable object in QueryData class.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    1af0fc1 View commit details
    Browse the repository at this point in the history

  2. Make ObservableQuery ignore stale results.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ea44203 View commit details
    Browse the repository at this point in the history

  3. Instead of ignoring stale results, never deliver them at all.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    f0c79ae View commit details
    Browse the repository at this point in the history

  4. Eliminate always-false ApolloQueryResult.stale field.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    c20bc74 View commit details
    Browse the repository at this point in the history

  5. Report Cache.MissingFieldError via Cache.DiffResult.missing array. 

    This new MissingFieldError type provides more information about the
location where the error occurred within the result object, while also
hiding the InvariantError type as an implementation detail.

It's important to continue using the InvariantError type internally to
give rollup-plugin-invariant a chance to strip the error messages from
production builds.
    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    6ef83e1 View commit details
    Browse the repository at this point in the history

  6. Reject with actual error in observableToPromise test helper.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    d6a17ca View commit details
    Browse the repository at this point in the history

  7. Simplify ApolloError constructor slightly.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    5d3a0c3 View commit details
    Browse the repository at this point in the history

  8. Log missing field errors in QueryListener function.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    788517f View commit details
    Browse the repository at this point in the history

  9. Mention PR #6058 in CHANGELOG.md.

    @benjamn
    benjamn committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    70ae548 View commit details
    Browse the repository at this point in the history