[3.0] Eviction of fields by specific arguments #6141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danReynolds: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
danReynolds
changed the title
danReynolds
changed the title
danReynolds
commented
Apr 12, 2020
danReynolds
commented
Apr 12, 2020
danReynolds
force-pushed
the
feature/evictFieldWithVariables
branch
from
c6b62e2
to
818cc82
Compare
This comment has been minimized.
This comment has been minimized.
benjamn
changed the title
danReynolds
force-pushed
the
feature/evictFieldWithVariables
branch
4 times, most recently
from
0037460
to
28b139e
Compare
danReynolds
commented
Apr 29, 2020
danReynolds
force-pushed
the
feature/evictFieldWithVariables
branch
from
572afc9
to
eb79a07
Compare
danReynolds
force-pushed
the
feature/evictFieldWithVariables
branch
from
e67d56e
to
f2a07d5
Compare
danReynolds
force-pushed
the
feature/evictFieldWithVariables
branch
2 times, most recently
from
575f532
to
1a91d05
Compare
When calling cache.evict, we do not have a FieldNode, so we cannot supply variables to be combined with the field's arguments, but must instead provide the fully-resolved arguments object. To make this work, the context argument of KeyArgsFunction no longer provides context.variables, since that information is not always available. The arguments passed as the first argument to the KeyArgsFunction should be sufficient to compute the field identity.
benjamn
force-pushed
the
feature/evictFieldWithVariables
branch
from
1a91d05
to
edff808
Compare
benjamn
approved these changes
May 8, 2020
There was a problem hiding this comment.
Approved with some tweaks to deal with args rather than variables (a subtle distinction, but important here IMO). Thanks for your patience @danReynolds!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of eviction by arguments API discussed here: #6098.
Evicts entities in the cache with exact matches of field names and arguments.