Supply TData generic removed in GraphQL v15 #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@durchanek: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Also closes #6125 |
benjamn
approved these changes
May 5, 2020
There was a problem hiding this comment.
Thanks @durchanek!
Note: I took the liberty of removing all internal uses of ExecutionResult, in favor of our FetchResult<TData> type.
benjamn
approved these changes
May 5, 2020
benjamn
added a commit
that referenced
this pull request
May 5, 2020
This version does *not* include my big PR #6221, which should be coming in the _next_ beta release. Code changes in beta.45 (since beta.44) include * #6194 by @durchanek * #6107 by @hwillson as well as several documentation PRs.
CarsonF
added a commit
to SeedCompany/cord-field
that referenced
this pull request
May 7, 2020
apollographql/apollo-client#6194 Unfortunately they have a release which is breaking semver, hence the need for the manual resolution. apollographql/apollo-client#6146
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets typings for
datato pre graphql@15 state and consistent with https://github.com/graphql/graphql-js/blob/master/src/execution/execute.d.ts#L48Related to #6111