Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand error types to match actual error data #6319

Merged
merged 1 commit into from
May 21, 2020
Merged

Expand error types to match actual error data #6319

merged 1 commit into from
May 21, 2020

Conversation

dmarkow
Copy link
Contributor

@dmarkow dmarkow commented May 20, 2020

Expands typing of ApolloError to include ServerError and ServerParseError. Fixes #6309

@apollo-cla
Copy link

@dmarkow: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@hwillson hwillson self-assigned this May 21, 2020
hwillson
hwillson approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks very much for working on this @dmarkow!

@hwillson hwillson merged commit 3d48f9f into apollographql:master May 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees

@hwillson hwillson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error types don't match actual error data
3 participants
@dmarkow @apollo-cla @hwillson