Update peerDependencies in package.json #6594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
approved these changes
Jul 14, 2020
This was referenced Jul 14, 2020
|
@hwillson I think you ought to reconsider this change. See this explanation. It's also been rejected in other prominent repos like React. tl;dr: it's likely that at some point in the future, a new major version of at least one of these peer dependencies will be released that isn't compatible with Apollo Client's use of it. This will cause Apollo Client to break without warning if the consumer upgrades this dependency. It's essentially the same reason why one wouldn't want to use |
|
Ahhh of course, great point @billyjanitsch. Thanks! |
benjamn
pushed a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twitter.com/SemanticRelease/status/1249795728253353986