Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export cache types from @apollo/client/core, again. #6725

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Re-export cache types from @apollo/client/core, again. #6725

merged 1 commit into from
Jul 28, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Jul 28, 2020

These types were lost in #6656 when I switched from

export * from '../cache'

to using named exports. There are some @apollo/client/cache exports that I wanted to omit from @apollo/client/core (like cacheSlot), but I definitely did not intend to omit these types!

Fixes #6723.

@benjamn
Re-export cache types from @apollo/client/core, again.
fc1371d 
These types were lost in #6656 when I switched from

  export * from '../cache'

to using named exports. There are some @apollo/client/cache exports that I
wanted to omit from @apollo/client/core (like cacheSlot), but I definitely
did not intend to omit these types.

Fixes #6723.
@benjamn benjamn self-assigned this Jul 28, 2020
@benjamn benjamn requested a review from hwillson July 28, 2020 23:57
@benjamn benjamn added this to the Post 3.0 milestone Jul 28, 2020
@benjamn benjamn mentioned this pull request Jul 28, 2020
Closed
hwillson
hwillson approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjamn!

@benjamn benjamn merged commit 0cf607f into master Jul 28, 2020
@benjamn benjamn deleted the reinstate-cache-type-exports branch July 28, 2020 23:59
benjamn added a commit that referenced this pull request Jul 29, 2020
@benjamn
Mention PR #6725 in CHANGELOG.md section for v3.1.1.
edb3954
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees

@benjamn benjamn

Labels
📟 regression ⛑ TypeScript
Projects
None yet
Milestone
Post 3.0
Development

Successfully merging this pull request may close these issues.

DataProxy and NormalizedCacheObject types not available from @apollo/client in 3.1 without deep import
2 participants
@benjamn @hwillson