Improvements for cache.modify: details.storage and details.INVALIDATE #6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're using options.storage in your custom read or merge functions, it can be useful to have access to it when using cache.modify as well.
hwillson
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
This looks great @benjamn! One more small documentation suggestion - adding INVALIDATE to https://www.apollographql.com/docs/react/api/cache/InMemoryCache/#modifier-functions would also be helpful. Thanks!
benjamn
changed the title
|
This happened while I was on vacation last week but just chiming in to say the changes are great! 🎉 |
Was 2c15bb4 lost somehow? I can't see it on the linked page. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the
options.storageobject fromreadandmergefunctions tocache.modifyfunctions, improving consistency between those APIs.Also,
cache.modifymodifier functions can now returndetails.INVALIDATE(similar todetails.DELETE) to invalidate the current field, causing affected queries to rerun, even if the field's value is unchanged. Previously, changing or deleting the field's value was the only way to invalidate the field.