Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup observer blocking unsubscribe (2) (#6985) #7170

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Fix cleanup observer blocking unsubscribe (2) (#6985) #7170

merged 3 commits into from
Oct 16, 2020

Commits on Oct 15, 2020

  1. Fix cleanup observer blocking unsubscribe (2) (apollographql#6985)

    Javier committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    2960a3e View commit details
    Browse the repository at this point in the history

  2. Simplify concast.addCount logic and unsubscribe asynchronously. 

    The test failure in apollographql#7170 was a case of unsubscribing the last observer
and then immediately resubscribing another observer, which should keep the
subscription alive, for backwards compatibility. Delaying the unsubscribe
to a later microtask tick enables this use case, while still unsubscribing
very soon after the last non-cleanup Concast observer unsubscribes.

In case there are still any cleanup observers in this.observers, and no
error or completion has been broadcast yet, we call this.handlers.error to
make sure those cleanup observers receive an error that terminates them.
    @benjamn
    benjamn committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    4ce6195 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Maintain MockLink public API

    Javier committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    ef936ed View commit details
    Browse the repository at this point in the history