ObservableQuery and QueryInfo stays forever on skip:true #7205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
I'd like to keep tearDownQuery private, but otherwise I approve of this solution. Thanks @kamilkisiela!
kamilkisiela
commented
Oct 22, 2020
benjamn
added a commit
that referenced
this pull request
Oct 29, 2020
Follow-up to #7205, per my comment in #7254: #7254 (comment) Instead of tearing down this.currentObservable only when this.getOptions().skip is true in QueryData#removeQuerySubscription, I split the tear-down functionality into a separate private method (QueryData#removeObservable), which is now called everywhere removeQuerySubscription is called, except in resubscribeToQuery, where we specifically want to preserve this.observableQuery.
benjamn
added a commit
that referenced
this pull request
Oct 30, 2020
Follow-up to #7205, per my comment in #7254: #7254 (comment) Instead of tearing down this.currentObservable only when this.getOptions().skip is true in QueryData#removeQuerySubscription, I split the tear-down functionality into a separate private method (QueryData#removeObservable), which is now called everywhere removeQuerySubscription is called, except in resubscribeToQuery, where we specifically want to preserve this.observableQuery.
|
Don’t mind this comment, just leaving this for future me: I came across this PR because I wanted to understand why we did |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7206
Cleanup logic is done on
unsubscribebut whenskip: truethe component never starts a subscription.I got the bottle over 3 years ago when Apollo was in very early stage, thank you once again :)