Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queryType:true, mutationType:true, and subscriptionType:true type policies. #7463

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Dec 11, 2020

Thanks to @zaguiini for tracking this regression (#7443) back to my type/field policy inheritance PR #7065 (and my commit c696b9a in particular).

Thanks to @zaguiini for tracking this regression (#7443) back to my
type/field policy inheritance PR (#7065).
@zaguiini
Copy link

How can I test this version locally?

@benjamn
Copy link
Member Author

benjamn commented Dec 11, 2020

@zaguiini Try this:

cd path/to/apollo-client
git fetch origin
git checkout -t 7443-fix-root-type-policies
npm install # just in case
npm run build
cd dist
npm pack
cd path/to/your/app
npm i ../path/to/apollo-client/dist/apollo-client-3.3.5.tgz

@zaguiini
Copy link

Hey @benjamn, that works perfectly. Everything is back to normal!

Thanks for fixing it so quickly and count on me to report new issues as they happen (I hope they don't!).

Cheers!

@benjamn benjamn merged commit 82c46ed into main Dec 11, 2020
@benjamn benjamn deleted the 7443-fix-root-type-policies branch December 11, 2020 23:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants