fix: setState after unmount #7655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DylanVann: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
jcreighton
reviewed
Feb 4, 2021
There was a problem hiding this comment.
@DylanVann Appreciate the work here but while these changes will resolve the error, it creates an issue for server-side rendering. We call forceUpdate during SSR but as useEffect hasn't fired yet, mounted.current will be false and forceUpdateUnsafe won't fire.
|
Thank you @jcreighton, I've changed it to use the original |
benjamn
approved these changes
Feb 9, 2021
added 2 commits
February 9, 2021 13:12
benjamn
added a commit
that referenced
this pull request
Feb 15, 2021
PR #7655 changed this code so that the Promise.resolve().then(forceUpdate) branch was not taken when queryDataRef.current was falsy, so forceUpdate() was called immediately instead (the else branch). As #7713 demonstrates, the Promise delay is important to avoid calling forceUpdate() synchronously during the initial render, which can lead to an infinite rendering loop. To preserve the intent of #7655, we now do the queryDataRef.current check inside the Promise callback, since the component could have been unmounted before the callback fired.
1 task
This was referenced Mar 11, 2021
This was referenced Mar 17, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing this error intermittently when running React in strict mode:
From the stack trace it seems to be coming from here, where the forceUpdate does not check if the component has unmounted.
Related issue: #6209
Checklist: