Add arg type to RefetchQueriesFunction #7850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fikrikarim
force-pushed
the
refetch-queries-function-type
branch
from
7cdbc3e
to
54b3eba
Compare
jpvajda
added
🏓 awaiting-contributor-response
|
Hi @fikrikarim 👋🏻 thanks so much for submitting this enhancement! I believe this would be appropriate to consider merging into our 4.0 release given that it's potentially breaking for some users (in a healthy way!) Have a great week and thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RefetchQueriesFunction has a FetchResult type on the documentation, but the type is
anyon the code right now.This PR add the type to
RefetchQueriesFunctionaccording to the documentation and the source code.If the type is wrong or there is something I need to change, just let me know and I'll try to update it.
Checklist:
If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)Make sure all of the significant new logic is covered by tests