Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Clarify usage of getDataFromTree #8434

Merged
merged 4 commits into from
Jul 13, 2021

Conversation

DanForys
Copy link
Contributor

Hello Apollo-client contributors!

This PR clarifies the docs around getDataFromTree to make clear that renderToStringWithData should be used instead, when rendering the tree directly to a string.

In my case, I spent half a day trying to figure out why React was giving me hydration mismatch warnings once I'd moved over to Apollo SSR. It was only after finding https://lihautan.com/hydrating-text-content/ I figured out the right thing to search for within the Apollo API and thought the main SSR docs would benefit from a small clarification.

Thanks!

@apollo-cla
Copy link

@DanForys: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch—thanks @DanForys!

@benjamn benjamn merged commit 5e5030c into apollographql:main Jul 13, 2021
benjamn pushed a commit to andreialecu/apollo-client that referenced this pull request Jul 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants