chore(docs): Clarify usage of getDataFromTree
#8434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Apollo-client contributors!
This PR clarifies the docs around
getDataFromTree
to make clear thatrenderToStringWithData
should be used instead, when rendering the tree directly to a string.In my case, I spent half a day trying to figure out why React was giving me hydration mismatch warnings once I'd moved over to Apollo SSR. It was only after finding https://lihautan.com/hydrating-text-content/ I figured out the right thing to search for within the Apollo API and thought the main SSR docs would benefit from a small clarification.
Thanks!