Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Missing cache result fields... warnings unless setLogVerbosity("debug") configured #8489

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Jul 12, 2021

Implementing the plan I described in #8442 (comment), building on apollographql/invariant-packages#155.

Here's where setLogVerbosity("log") is called by default. Note that all invariant.* log messages (of any level) are always hidden in production, so the setLogVerbosity configuration matters only in development.

@benjamn benjamn requested a review from brainkim July 12, 2021 17:08
@benjamn benjamn self-assigned this Jul 12, 2021
@benjamn benjamn added this to the MM - July 2021 milestone Jul 12, 2021
@benjamn benjamn added this to In progress in Release 3.4 Jul 12, 2021
@benjamn benjamn changed the title Suppress "Missing cache result fields..." warnings unless setLogVerbosity("debug") configured Suppress Missing cache result fields... warnings unless setLogVerbosity("debug") configured Jul 12, 2021
@benjamn benjamn merged commit e9cf7c1 into release-3.4 Jul 12, 2021
@benjamn benjamn deleted the suppress-missing-cache-result-fields-warnings branch July 12, 2021 19:13
@benjamn benjamn linked an issue Jul 12, 2021 that may be closed by this pull request
@hwillson hwillson moved this from In progress to Done in Release 3.4 Jul 15, 2021
@hwillson hwillson removed this from the MM-2021-07 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[v3.4] Unexpected Console Warning: "Missing cache result fields"
3 participants