Added @apollo/client/testing/core entry point #8687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainkim
reviewed
Aug 23, 2021
benjamn
reviewed
Aug 24, 2021
benjamn
added a commit
that referenced
this pull request
Sep 10, 2021
#8687 (comment) Until now, the `@apollo/client/testing` entry point has merely re-exported the contents of `@apollo/client/utilities/testing`, even though the latter is not an official entry point, leading to "Risky cross-entry-point nested import..." warnings during build. This commit moves the contents of `@apollo/client/utilities/testing` to actually reside within `@apollo/client/testing`, which should be safe because `@apollo/client/testing` was the only safe way to access these modules before now.
benjamn
added a commit
that referenced
this pull request
Sep 10, 2021
#8687 (comment) Until now, the `@apollo/client/testing` entry point has merely re-exported the contents of `@apollo/client/utilities/testing`, even though the latter is not an official entry point, leading to "Risky cross-entry-point nested import..." warnings during build. This commit moves the contents of `@apollo/client/utilities/testing` to reside within `@apollo/client/testing`, which should be safe because `@apollo/client/testing` was the only safe way to access these modules previously.
benjamn
added a commit
that referenced
this pull request
Sep 10, 2021
#8687 (comment) Until now, the `@apollo/client/testing` entry point has merely re-exported the contents of `@apollo/client/utilities/testing`, even though the latter is not an official entry point, leading to "Risky cross-entry-point nested import..." warnings during build. This commit moves the contents of `@apollo/client/utilities/testing` to reside within `@apollo/client/testing`, which should be safe because `@apollo/client/testing` was the only safe way to access these modules previously.
benjamn
changed the base branch from
master
to
make-@apollo/client/testing-an-entry-point
benjamn
added a commit
that referenced
this pull request
Sep 10, 2021
#8687 (comment) Until now, the `@apollo/client/testing` entry point has merely re-exported the contents of `@apollo/client/utilities/testing`, even though the latter is not an official entry point, leading to "Risky cross-entry-point nested import..." warnings during build. This commit moves the contents of `@apollo/client/utilities/testing` to reside within `@apollo/client/testing`, which should be safe because `@apollo/client/testing` was the only safe way to access these modules previously.
benjamn
force-pushed
the
make-@apollo/client/testing-an-entry-point
branch
from
9861f01
to
bc9f401
Compare
benjamn
force-pushed
the
feature/testing-core-entry-point
branch
from
e175d4b
to
634a86d
Compare
benjamn
added a commit
to wassim-k/apollo-client
that referenced
this pull request
Sep 10, 2021
benjamn
changed the base branch from
make-@apollo/client/testing-an-entry-point
to
release-3.5
benjamn
force-pushed
the
feature/testing-core-entry-point
branch
from
3346ab5
to
e3f5ed9
Compare
|
These changes are now available in As a sign this is working, you should be able to do this in a browser console: await import("https://esm.run/@apollo/client@3.5.0-beta.13/testing/core")whereas this (still) doesn't work, because of the React dependencies: await import("https://esm.run/@apollo/client@3.5.0-beta.13/testing") |
|
@benjamn works like a treat, thanks heaps for the great work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
MockLinkandMockSubscriptionLinkfrom@apollo/client/testingare quite useful for running unit tests against apollo client logic.The only issue is that
@apollo/client/testinghas a direct dependency onreactthroughMockedProviderwhich makes it unusable for other frameworks like Angular that would like to make use of the testing framework without having to pull inreactand all of its dependencies.This PR introduces a new entry point
@apollo/client/testing/corewhich is identical to@apollo/client/testingexcept it doesn't exportMockedProviderallowing other frameworks to make use of it without having to depend onreact.I made sure non of the existing entry points and exports are affected by this change so everything should work as it always has.
I hope you find this useful and please let me know if you can think of other better ways to solve this issue.
Thanks.