Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query whitespace, take 2: Function Time #8699

Merged

Conversation

sarahghp
Copy link
Contributor

@sarahghp sarahghp commented Aug 25, 2021

Implements approach for optionally removing removing whitespace or otherwise passing custom print functions to HttpLink and friends as outlined in #8549.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@sarahghp: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@sarahghp
Copy link
Contributor Author

sarahghp commented Aug 25, 2021

@benjamn Do you mind taking a look at this draft and confirming the approach matches expectations? Then I'll go in and add new specs and docs, update filesize, etc. Thanks!

@benjamn
Copy link
Member

benjamn commented Aug 25, 2021

@sarahghp This is looking great/perfect so far!

If you rebase and force-push I believe the CLA check will pass. And please feel free to bump the bundlesize limit here to, say, 24.8kB. That will more than cover the increase from this PR (~0.05kB, way less than before 🎉).

@benjamn benjamn added this to the Release 3.5 milestone Aug 25, 2021
@sarahghp sarahghp force-pushed the remove-query-whitespace-take-ii branch from bc55764 to 82e41b6 Compare August 26, 2021 09:21
@sarahghp sarahghp changed the title Draft: Remove query whitespace, take 2: Function Time Remove query whitespace, take 2: Function Time Aug 30, 2021
@sarahghp
Copy link
Contributor Author

@benjamn @StephenBarlow This is ready for feedback on specs and docs now. Thank you!

@benjamn benjamn force-pushed the remove-query-whitespace-take-ii branch from 53d9ed2 to bdc0733 Compare August 30, 2021 16:22
benjamn added a commit to sarahghp/apollo-client that referenced this pull request Aug 30, 2021
benjamn added a commit to sarahghp/apollo-client that referenced this pull request Aug 30, 2021
@benjamn benjamn force-pushed the remove-query-whitespace-take-ii branch from 05f8c76 to 5283433 Compare August 30, 2021 16:38
benjamn added a commit to sarahghp/apollo-client that referenced this pull request Aug 30, 2021
@benjamn benjamn force-pushed the remove-query-whitespace-take-ii branch from 5283433 to c552a44 Compare August 30, 2021 18:43
@benjamn benjamn changed the base branch from main to release-3.5 August 30, 2021 18:43
@benjamn benjamn force-pushed the remove-query-whitespace-take-ii branch from c552a44 to 93f891e Compare August 30, 2021 18:49
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests and docs!

I rebased against release-3.5 (since this is technically new functionality), and I expect to release these changes in @apollo/client@3.5.0-beta.11 (the next beta release).

I'll let @StephenBarlow review these documentation changes asynchronously.

@benjamn benjamn merged commit 02f0083 into apollographql:release-3.5 Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants