Improve handling of falsy existing and/or incoming parameters in relayStylePagination
#8733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2021
Closed
|
what still needs to be taken and merged? @benjamn |
|
Looks good! Sorry about the delay, this was opened before the break. Let’s get this merged and shipped! |
benjamn
force-pushed
the
tolerate-relayStylePagination-falsy-inputs
branch
from
04c026a
to
6e0ba4a
Compare
|
Merging even though I believe that test failure is spurious, since that test has been failing recently on |
2 tasks
|
awesome guys! great job here |
kainosnoema
reviewed
Nov 3, 2021
Comment on lines
+137
to
+139
| if (!existing) { | ||
| existing = makeEmptyData(); | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #7949 by @bubba, and hopefully fixing #7822.