Associate Apollo context with React.createContext (instead of using a local WeakMap) again
#8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
associate-context-with-React.createContext-again
branch
from
26810b3
to
b9c3f0a
Compare
benjamn
added a commit
that referenced
this pull request
Sep 16, 2021
benjamn
force-pushed
the
associate-context-with-React.createContext-again
branch
from
b9c3f0a
to
11f485e
Compare
Should fix #8790, by allowing multiple copies of `@apollo/client` (uncommon) to share the same `React.createContext[contextKey]` object.
benjamn
force-pushed
the
associate-context-with-React.createContext-again
branch
from
11f485e
to
d1b8d0e
Compare
hwillson
approved these changes
Sep 17, 2021
benjamn
deleted the
associate-context-with-React.createContext-again
branch
|
@benjamn @hwillson My vue 2.6 projects are failing to run/build after upgrading the apollo client dependency to 3.4.12. Log: Reverting to 3.4.11 fixes the problem. Thanks. |
benjamn
commented
Sep 20, 2021
| @@ -1,4 +1,5 @@ | |||
| import { Observable } from "./Observable"; | |||
| import { canUseSymbol } from ".."; | |||
There was a problem hiding this comment.
This line seems to have caused a number of problems, hopefully all fixed by #8817.
|
@ruben-nogueira Please try |
|
@benjamn it's okay. Thanks again. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #8790, by allowing multiple copies of
@apollo/client(uncommon) to share the sameReact.createContext[contextKey]object.A lot has changed since #7371, but I am not worried about
React.createContextbeing undefined, because (in this module,ApolloContext.ts), theReactobject is now a namespace object (thanks toimport * as React from 'react'), and we callReact.createContextunconditionally withingetApolloContextalready, soReact.createContextmust be defined whengetApolloContextis called, or this code would be totally broken.This implementation uses
React.createContext[contextKey]instead ofReact[contextKey](as in #7371) because theReactnamespace object is likely frozen/non-extensible, whereasReact.createContextis an ordinary function object.