Clear InMemoryCache watches when cache.reset() called
#8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help with memory management during SSR, per my comment #7942 (comment)
benjamn
commented
Sep 22, 2021
hwillson
approved these changes
Sep 23, 2021
benjamn
added a commit
that referenced
this pull request
Sep 27, 2021
As reported in issue #8851, PR #8826 was a breaking change for code expecting cache.watches to be restarted after cache.reset() is called. This commit establishes a small but extensible Cache.ResetOptions API for the cache.reset method, which allows the handling of watches to be configured via options.discardWatches, which defaults to false, thus restoring the behavior of cache.reset() from before #8826. If you need the behavior introduced by #8826, you can now opt (back) into that behavior by calling cache.reset({ discardWatches: true }).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help with memory management during SSR (provided
cache.reset()is called), per my comment #7942 (comment).Reusing the same cache between SSR requests is typically not what we recommend, since creating a new client/cache for each request is such an easy and effective way to prevent data from leaking between requests from different users/clients.
However, if you're careful to reset the cache each time, or you have non-SSR reasons for resetting the cache, it seems reasonable to expect the
cache.watchesto be emptied after the reset.