Update Jest-related dependencies to latest version (v27) to address npm audit problems
#9004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brainkim The remaining |
benjamn
commented
Nov 4, 2021
| @@ -17,4 +17,5 @@ module.exports = { | |||
| moduleFileExtensions: ['ts', 'tsx', 'js', 'json'], | |||
| testURL: 'http://localhost', | |||
| setupFiles: ['<rootDir>/config/jest/setup.ts'], | |||
| testEnvironment: 'jsdom', | |||
There was a problem hiding this comment.
Here's the change that reenables jsdom for all tests. Should we restrict it to the ones that actually need it?
benjamn
commented
Nov 4, 2021
| jest.runTimersToTime(230); | ||
| jest.advanceTimersByTime(230); |
There was a problem hiding this comment.
Fortunately this was just a cosmetic change (renamed for clarity/accuracy): jestjs/jest#4723
brainkim
approved these changes
Nov 4, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest 27.0.0 was a significant major release with a number of breaking changes, so it's no surprise PRs like #8477 are failing. This PR is my manual attempt to address all of the hurdles involved in updating.
Closes #8324, #8841, #8910, #8325, #8477
The necessary changes fall into a few different categories:
jsdomenvironment so tests running in Node.js have access to mockwindowanddocumentobjects (one-line change inconfig/jest.config.js)done.failand the globalfailfunction (many similar changes, mostly convertingdone-style tests to use promises)jest.runTimersToTimeto the more accurately namedjest.advanceTimersToTimeIt might go without saying, but a huge shout-out to TypeScript for making this kind of migration relatively straightforward, compared to the painstaking care that would be required if this was all pure JavaScript.
Perhaps more importantly, these updates collectively resolve a number of high-severity security vulnerabilities (not confirmed to have any impact on
@apollo/client, but worth addressing).Before this PR (note how many of these problems are Jest-dependency-related):
With this PR:
I will continue investigating what's necessary to get this number down to zero.